third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image.html - Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image.html

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, resolve comment rewrap conflicts. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/resources/frame-loading-via-document-write.js ('k') | third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image-expected.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 Test for crbug.com/380885: images should not be requested in an SVG image contex t.<br><br>	2 Test for crbug.com/380885: images should not be requested in an SVG image contex t.<br><br>

3 Image loaded via object should show a green background with a cross-origin image of Abe Lincoln:<br>	3 Image loaded via object should show a green background with a cross-origin image of Abe Lincoln:<br>

4 <object id="precache" data="resources/image-wrapper.svg" width="100" height="100 "></object>	4 <object id="precache" data="resources/image-wrapper.svg" width="100" height="100 "></object>

5 <br>	5 <br>

6 Image loaded via img should show a green background without the remote image of Abe Lincoln:<br>	6 Image loaded via img should show a green background with fallback content instea d of the remote image of Abe Lincoln:<br>

7 <img id="image" src="" width="100" height="100">	7 <img id="image" src="" width="100" height="100">

8 <script>	8 <script>

9 if (window.testRunner)	9 if (window.testRunner)

10 testRunner.waitUntilDone();	10 testRunner.waitUntilDone();

11	11

12 document.getElementById('precache').onload = function() {	12 document.getElementById('precache').onload = function() {

13 // FIXME: crbug.com/382170 SVG onload event bug.	13 // FIXME: crbug.com/382170 SVG onload event bug.

14 setTimeout(function() {	14 setTimeout(function() {

15 var image = document.getElementById('image');	15 var image = document.getElementById('image');

16 image.onload = function() {	16 image.onload = function() {

17 // FIXME: crbug.com/382170 SVG onload event bug.	17 // FIXME: crbug.com/382170 SVG onload event bug.

18 setTimeout(function() {	18 setTimeout(function() {

19 if (window.testRunner)	19 if (window.testRunner)

20 testRunner.notifyDone();	20 testRunner.notifyDone();

21 }, 20);	21 }, 20);

22 }	22 }

23 image.src = "resources/image-wrapper.svg";	23 image.src = "resources/image-wrapper.svg";

24 }, 20);	24 }, 20);

25 }	25 }

26	26

27 </script>	27 </script>

OLD	NEW