third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image-expected.html - Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image-expected.html

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, resolve comment rewrap conflicts. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/svg-image-with-cached-remote-image.html ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 Test for crbug.com/380885: images should not be requested in an SVG image contex t.<br><br>	2 Test for crbug.com/380885: images should not be requested in an SVG image contex t.<br><br>

3 Image loaded via object should show a green background with a cross-origin image of Abe Lincoln:<br>	3 Image loaded via object should show a green background with a cross-origin image of Abe Lincoln:<br>

4 <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlin k" width="100" height="100">	4 <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlin k" width="100" height="100">

5 <rect width="100%" height="100%" fill="#0f0"/>	5 <rect width="100%" height="100%" fill="#0f0"/>

6 <rect x="20%" y="20%" width="60%" height="60%" stroke-width="1" stroke="blac k" fill="transparent"/>	6 <rect x="20%" y="20%" width="60%" height="60%" stroke-width="1" stroke="blac k" fill="transparent"/>

7 <image xlink:href="resources/abe.png" x="20%" y="20%" width="60%" height="60 %"/>	7 <image xlink:href="resources/abe.png" x="20%" y="20%" width="60%" height="60 %"/>

8 </svg>	8 </svg>

9	9

10 <br>	10 <br>

11 Image loaded via img should show a green background without the remote image of Abe Lincoln:<br>	11 Image loaded via img should show a green background with fallback content instea d of the remote image of Abe Lincoln:<br>

12 <svg width="100" height="100">	12 <svg width="100" height="100">

13 <rect width="100%" height="100%" fill="#0f0"/>	13 <rect width="100%" height="100%" fill="#0f0"/>

14 <rect x="20%" y="20%" width="60%" height="60%" stroke-width="1" stroke="blac k" fill="transparent"/>	14 <rect x="20%" y="20%" width="60%" height="60%" stroke-width="1" stroke="blac k" fill="transparent"/>

15 </svg>	15 <image xlink:href="non-existent-resource-to-produce-fallback-content" x="20% " y="20%" width="60%" height="60%"/>

	16 </svg>

OLD	NEW