Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2231493002: Add lint suppression to android values. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add lint suppression to android values. This CL removes 40 MissingTranslation lint warnings. These string resources are only used in code and do not need to be translated. BUG=635967 Committed: https://crrev.com/a31162000b01be6c94a3a1f8921c31620ccbc5f5 Cr-Commit-Position: refs/heads/master@{#410776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/res/values/values.xml View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
estevenson
ptal
4 years, 4 months ago (2016-08-09 18:20:41 UTC) #6
gone
lgtm
4 years, 4 months ago (2016-08-09 18:31:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231493002/1
4 years, 4 months ago (2016-08-09 19:41:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 19:50:50 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 19:52:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a31162000b01be6c94a3a1f8921c31620ccbc5f5
Cr-Commit-Position: refs/heads/master@{#410776}

Powered by Google App Engine
This is Rietveld 408576698