Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2231433002: Revert of Remove unnecessary page loading in ContentShellActivity (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Peter Beverloo, jam, darin-cc_chromium.org, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unnecessary page loading in ContentShellActivity (patchset #2 id:20001 of https://codereview.chromium.org/2199223002/ ) Reason for revert: ContentViewZoomingTest.testJoystickZoomOut is now very flaky in almost all configurations, including on the main waterfall. crbug.com/635940 Original issue's description: > Remove unnecessary page loading in ContentShellActivity > > In ContentShellActivity#onCreate, we load the page twice: one is the > default page and the other is the target page. The second loading can > be avoided if we load the target page in the first loading. Thus, we can > be sure that the target page will be ready once the page stops loading. > > assertWaitForPageScaleFactorMatch() used to be a workaround for the > flaky bug crbug.com/179511 . The tests are not flaky anymore after > applying this patch. Thus, we can remove it. > > BUG=580419, 179511 > > Committed: https://crrev.com/797581eba513a69c80fbcbff43817b6fc6c6a9c0 > Cr-Commit-Position: refs/heads/master@{#410519} TBR=changwan@chromium.org,aelias@chromium.org,sievers@chromium.org,yabinh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=580419, 179511 Committed: https://crrev.com/a7c4fa85692c0201f91eaa82a4161ee2e4958201 Cr-Commit-Position: refs/heads/master@{#410677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java View 5 chunks +5 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java View 3 chunks +3 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewZoomingTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/EmailAddressDetectionTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java View 4 chunks +4 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/android/browsertests/src/org/chromium/content_shell/browsertests/ContentShellBrowserTestActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 3 chunks +20 lines, -1 line 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbudorick
Created Revert of Remove unnecessary page loading in ContentShellActivity
4 years, 4 months ago (2016-08-09 15:28:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231433002/1
4 years, 4 months ago (2016-08-09 15:28:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 15:29:52 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 15:33:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7c4fa85692c0201f91eaa82a4161ee2e4958201
Cr-Commit-Position: refs/heads/master@{#410677}

Powered by Google App Engine
This is Rietveld 408576698