DescriptionRevert of Remove unnecessary page loading in ContentShellActivity (patchset #2 id:20001 of https://codereview.chromium.org/2199223002/ )
Reason for revert:
ContentViewZoomingTest.testJoystickZoomOut is now very flaky in almost all configurations, including on the main waterfall. crbug.com/635940
Original issue's description:
> Remove unnecessary page loading in ContentShellActivity
>
> In ContentShellActivity#onCreate, we load the page twice: one is the
> default page and the other is the target page. The second loading can
> be avoided if we load the target page in the first loading. Thus, we can
> be sure that the target page will be ready once the page stops loading.
>
> assertWaitForPageScaleFactorMatch() used to be a workaround for the
> flaky bug crbug.com/179511 . The tests are not flaky anymore after
> applying this patch. Thus, we can remove it.
>
> BUG=580419, 179511
>
> Committed: https://crrev.com/797581eba513a69c80fbcbff43817b6fc6c6a9c0
> Cr-Commit-Position: refs/heads/master@{#410519}
TBR=changwan@chromium.org,aelias@chromium.org,sievers@chromium.org,yabinh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580419, 179511
Committed: https://crrev.com/a7c4fa85692c0201f91eaa82a4161ee2e4958201
Cr-Commit-Position: refs/heads/master@{#410677}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|