Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chromecast/net/network_change_notifier_cast.h

Issue 223143003: Initial checkin of chromecast content embedder (cast_shell) and related build scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ScreenCast code and stale comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/net/network_change_notifier_cast.h
diff --git a/chromecast/net/network_change_notifier_cast.h b/chromecast/net/network_change_notifier_cast.h
new file mode 100644
index 0000000000000000000000000000000000000000..6457662dd7558f96ece6940c2aab667a0cfd5971
--- /dev/null
+++ b/chromecast/net/network_change_notifier_cast.h
@@ -0,0 +1,34 @@
+// Copyright 2014 Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMECAST_NET_NETWORK_CHANGE_NOTIFIER_CAST_H_
+#define CHROMECAST_NET_NETWORK_CHANGE_NOTIFIER_CAST_H_
+
+#include "base/basictypes.h"
Ryan Sleevi 2014/07/01 21:13:55 use "base/macros.h" for DISALLOW
lcwu1 2014/07/02 23:30:33 Done. Also added this include in the other header
+#include "base/compiler_specific.h"
+#include "net/base/network_change_notifier.h"
+
+namespace net {
+
+// TODO(lcwu): This is a place holder for cast-specific NetworkChangeNotifier
+// implementation. The actual implementation of this class will come in
+// later CLs after we clean up the code.
Ryan Sleevi 2014/07/01 21:13:55 1) Avoid pronouns in comments ( https://groups.goo
lcwu1 2014/07/02 23:30:33 Done. Also fixed the same issue in several other
+class NetworkChangeNotifierCast : public NetworkChangeNotifier {
+ public:
+ NetworkChangeNotifierCast();
+ virtual ~NetworkChangeNotifierCast();
+
+ // Implementation of net::NetworkChangeNotifier.
Ryan Sleevi 2014/07/01 21:13:55 You use inconsistent comment styles here with this
lcwu1 2014/07/02 23:30:33 Done.
+ virtual NetworkChangeNotifier::ConnectionType
+ GetCurrentConnectionType() const OVERRIDE;
+
+ private:
+ friend class NetworkChangeNotifierCastTest;
+
+ DISALLOW_COPY_AND_ASSIGN(NetworkChangeNotifierCast);
+};
+
+} // namespace net
+
+#endif // CHROMECAST_NET_NETWORK_CHANGE_NOTIFIER_CAST_H_

Powered by Google App Engine
This is Rietveld 408576698