Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2231403002: Allow Dart package.stamp file to be missing in dart2js_nobuild recipe (Closed)

Created:
4 years, 4 months ago by Bill Hesse
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Allow Dart package.stamp file to be missing in dart2js_nobuild recipe BUG= R=sgjesse@google.com Committed: https://chromium.googlesource.com/chromium/tools/build/+/5d1a4325cb496b888ee88d6707fbe4174f19a041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scripts/slave/recipes/dart/dart2js_nobuild.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Bill Hesse
No change to recipe expectations due to this change.
4 years, 4 months ago (2016-08-11 12:22:33 UTC) #1
Søren Gjesse
lgtm
4 years, 4 months ago (2016-08-11 12:31:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231403002/1
4 years, 4 months ago (2016-08-11 14:53:49 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-11 14:53:51 UTC) #6
William Hesse
lgtm
4 years, 4 months ago (2016-08-11 14:55:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231403002/1
4 years, 4 months ago (2016-08-11 14:55:17 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:59:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/5d1a4325cb496b888ee8...

Powered by Google App Engine
This is Rietveld 408576698