Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 22314017: Do not use guarded cid on externalizable cid-s (one and two byte strings). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_type_propagator.cc
===================================================================
--- runtime/vm/flow_graph_type_propagator.cc (revision 25890)
+++ runtime/vm/flow_graph_type_propagator.cc (working copy)
@@ -945,14 +945,19 @@
}
if (FLAG_enable_type_checks) {
+ ASSERT(!type().HasResolvedTypeClass() ||
+ !Field::IsExternalizableCid(Class::Handle(
+ type().type_class()).id()));
return CompileType::FromAbstractType(type());
}
- if (field_ != NULL && (field_->guarded_cid() != kIllegalCid)) {
+ if ((field_ != NULL) && (field_->guarded_cid() != kIllegalCid)) {
+ ASSERT(!Field::IsExternalizableCid(field_->guarded_cid()));
return CompileType::CreateNullable(field_->is_nullable(),
field_->guarded_cid());
}
+ ASSERT(!Field::IsExternalizableCid(result_cid_));
return CompileType::FromCid(result_cid_);
}
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/object.h » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698