Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 22314010: ARM/MIPS: Fix Constant-to-DoubleRegister moves in LGapResolver (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow
Modified:
7 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

ARM/MIPS: Fix Constant-to-DoubleRegister moves in LGapResolver R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/arm/lithium-gap-resolver-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-gap-resolver-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
The condition in question was always trivially false before. With the fix, it'll still be ...
7 years, 4 months ago (2013-08-06 13:13:39 UTC) #1
Benedikt Meurer
Well spotted, LGTM.
7 years, 4 months ago (2013-08-06 13:19:19 UTC) #2
Jakob Kummerow
7 years, 4 months ago (2013-08-06 14:47:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698