android_webview/all_webview.gyp - Issue 22314005: [Android] On calling openNewTab, pass the disposition instead of incognito.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/all_webview.gyp

Issue 22314005: [Android] On calling openNewTab, pass the disposition instead of incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: @param disposition comment revision Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/Android.mk ('k') | android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java » ('j') | ui/base/window_open_disposition.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/all_webview.gyp

diff --git a/android_webview/all_webview.gyp b/android_webview/all_webview.gyp

index 6af2c69fa52b450a9dda6ca11c944dbcf764082d..e3e3fea5eb8df36ae8c2cc76a42ce80855e9b5ff 100644

--- a/android_webview/all_webview.gyp

+++ b/android_webview/all_webview.gyp

@@ -24,6 +24,7 @@

'../net/net.gyp:cert_verify_result_android_java',

'../net/net.gyp:net_errors_java',

'../net/net.gyp:private_key_types_java',

+ '../ui/ui.gyp:window_open_disposition_java',

}, # target_name: All

], # targets