DevTools Security panel: Update the sidebar to match new Material specs.

DevTools Security panel: Update the sidebar to match new Material specs.

This CL also simplifies the CSS in favor of using inherited tree-outline values where possible.

BUG=617311

[lgarron, 2016-08-13 00:03:19]

lgarron@chromium.org changed reviewers:
+ pfeldman@chromium.org

[lgarron, 2016-08-13 00:03:20]

pfeldman@, could you review?

See https://bugs.chromium.org/p/chromium/issues/detail?id=617311#c13 for
screenshots.

[pfeldman, 2016-08-13 00:08:09]

https://codereview.chromium.org/2231383003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/security/sidebar.css (right):

https://codereview.chromium.org/2231383003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/security/sidebar.css:11: /* Hide
dropdown triangles, since the Security panel doesn't use them. */
They still work though.

[lgarron, 2016-08-13 00:42:27]

https://codereview.chromium.org/2231383003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/security/sidebar.css (right):

https://codereview.chromium.org/2231383003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/security/sidebar.css:11: /* Hide
dropdown triangles, since the Security panel doesn't use them. */
On 2016/08/13 at 00:08:09, pfeldman wrote:
> They still work though.

Really? I can't click on them.

(Note: this is not a new part of the file, I just moved it up and added a
clarifying comment because the purpose wasn't immediately obvious to me.)

[pfeldman, 2016-08-15 17:21:52]

lgtm

[pfeldman, 2016-08-15 17:23:17]

On 2016/08/15 17:21:52, pfeldman wrote:
> lgtm

Actually, let me take it back. I think we should fix the bugs from the backlog
instead of updating for the Material. You change is likely to regress something,
while we already have 30+ bugs on your feature. not lgtm.

[lgarron, 2016-08-15 17:57:12]

On 2016/08/15 at 17:23:17, pfeldman wrote:
> On 2016/08/15 17:21:52, pfeldman wrote:
> > lgtm
> 
> Actually, let me take it back. I think we should fix the bugs from the backlog
instead of updating for the Material. You change is likely to regress something,
while we already have 30+ bugs on your feature. not lgtm.

Why is it likely to regress something?
I can respect if you'd like to block UI changes while there is a backlog, but
this is purely CSS and almost entirely whitespace fixes.

[lgarron, 2016-08-15 18:04:35]

On 2016/08/15 at 17:57:12, lgarron wrote:
> On 2016/08/15 at 17:23:17, pfeldman wrote:
> > On 2016/08/15 17:21:52, pfeldman wrote:
> > > lgtm
> > 
> > Actually, let me take it back. I think we should fix the bugs from the
backlog instead of updating for the Material. You change is likely to regress
something, while we already have 30+ bugs on your feature. not lgtm.
> 
> Why is it likely to regress something?
> I can respect if you'd like to block UI changes while there is a backlog, but
this is purely CSS and almost entirely whitespace fixes.

(Also note that I'm not trying to land any Material CLs that change the panel's
behaviour right now.)

[vinodsonkusare77_gmail.com, 2016-08-17 10:08:58]

https://youtu.be/s2mEASqcipA?list=UUWQUZfAdokV83KKjLl-sDeQ

On Mon, Aug 15, 2016 at 11:34 PM, <lgarron@chromium.org> wrote:

> On 2016/08/15 at 17:57:12, lgarron wrote:
> > On 2016/08/15 at 17:23:17, pfeldman wrote:
> > > On 2016/08/15 17:21:52, pfeldman wrote:
> > > > lgtm
> > >
> > > Actually, let me take it back. I think we should fix the bugs from the
> backlog instead of updating for the Material. You change is likely to
> regress
> something, while we already have 30+ bugs on your feature. not lgtm.
> >
> > Why is it likely to regress something?
> > I can respect if you'd like to block UI changes while there is a
> backlog, but
> this is purely CSS and almost entirely whitespace fixes.
>
> (Also note that I'm not trying to land any Material CLs that change the
> panel's
> behaviour right now.)
>
> https://codereview.chromium.org/2231383003/
>
> --
> You received this message because you are subscribed to the Google Groups
> "DevTools Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to devtools-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[vinodsonkusare77_gmail.com, 2016-08-17 10:09:00]

https://youtu.be/s2mEASqcipA?list=UUWQUZfAdokV83KKjLl-sDeQ

On Mon, Aug 15, 2016 at 11:34 PM, <lgarron@chromium.org> wrote:

> On 2016/08/15 at 17:57:12, lgarron wrote:
> > On 2016/08/15 at 17:23:17, pfeldman wrote:
> > > On 2016/08/15 17:21:52, pfeldman wrote:
> > > > lgtm
> > >
> > > Actually, let me take it back. I think we should fix the bugs from the
> backlog instead of updating for the Material. You change is likely to
> regress
> something, while we already have 30+ bugs on your feature. not lgtm.
> >
> > Why is it likely to regress something?
> > I can respect if you'd like to block UI changes while there is a
> backlog, but
> this is purely CSS and almost entirely whitespace fixes.
>
> (Also note that I'm not trying to land any Material CLs that change the
> panel's
> behaviour right now.)
>
> https://codereview.chromium.org/2231383003/
>
> --
> You received this message because you are subscribed to the Google Groups
> "DevTools Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to devtools-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[lgarron, 2016-09-07 05:01:15]

lgarron@chromium.org changed reviewers:
- vinodsonkusare77@gmail.com

[lgarron, 2016-09-07 05:01:15]

(Removing bogus reviewer. lApparently it's not possible to delete spam comments,
though. [1])


[1] https://github.com/rietveld-codereview/rietveld/issues/386

[pfeldman, 2017-02-23 01:22:05]

Description was changed from

==========
DevTools Security panel: Update the sidebar to match new Material specs.

This CL also simplifies the CSS in favor of using inherited tree-outline values
where possible.

BUG=617311
==========

to

==========
DevTools Security panel: Update the sidebar to match new Material specs.

This CL also simplifies the CSS in favor of using inherited tree-outline values
where possible.

BUG=617311
==========

[pfeldman, 2017-02-23 01:22:05]

pfeldman@chromium.org changed reviewers:
- pfeldman@chromium.org