Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2231363002: Logger does not need to invoke the garbage collector to iterate the heap. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Logger does not need to invoke the garbage collector to iterate the heap. BUG= Committed: https://crrev.com/76b5353493c30244055162f13d76cb8bf87e65fb Cr-Commit-Position: refs/heads/master@{#38574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/log.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Lippautz
lgtm
4 years, 4 months ago (2016-08-11 09:31:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231363002/1
4 years, 4 months ago (2016-08-11 10:47:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 10:49:10 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 10:49:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76b5353493c30244055162f13d76cb8bf87e65fb
Cr-Commit-Position: refs/heads/master@{#38574}

Powered by Google App Engine
This is Rietveld 408576698