Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: extensions/browser/file_reader.h

Issue 2231353002: Make FileReader return ownership of the string content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/file_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/file_reader.h
diff --git a/extensions/browser/file_reader.h b/extensions/browser/file_reader.h
index 10a65ff6b8cff198e1903a69b1546caae16375e6..9b391f8635be496d1792bfa6d52f4307aec29bc3 100644
--- a/extensions/browser/file_reader.h
+++ b/extensions/browser/file_reader.h
@@ -19,7 +19,7 @@
class FileReader : public base::RefCountedThreadSafe<FileReader> {
public:
// Reports success or failure and the data of the file upon success.
- typedef base::Callback<void(bool, const std::string&)> Callback;
+ typedef base::Callback<void(bool, std::unique_ptr<std::string>)> Callback;
FileReader(const extensions::ExtensionResource& resource,
const Callback& callback);
« no previous file with comments | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/file_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698