Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2833)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_manager.cc

Issue 2231353002: Make FileReader return ownership of the string content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/execute_code_function.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/accessibility/accessibility_manager.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
index 8dee33378a3c86e0d7c1713a8b918fa7281fa7aa..b0ab895f54e5c03cb45123ec6f5afaab718d1611 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
@@ -190,12 +190,12 @@ class ContentScriptLoader {
}
private:
- void OnFileLoaded(bool success, const std::string& data) {
+ void OnFileLoaded(bool success, std::unique_ptr<std::string> data) {
if (success) {
RenderViewHost* render_view_host =
RenderViewHost::FromID(render_process_id_, render_view_id_);
if (render_view_host)
- ExecuteScriptHelper(render_view_host, data, extension_id_);
+ ExecuteScriptHelper(render_view_host, *data, extension_id_);
}
Run();
}
« no previous file with comments | « no previous file | extensions/browser/api/execute_code_function.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698