components/autofill/content/renderer/password_autofill_agent.h - Issue 223133003: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 223133003: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed problems in previous patch Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/common/autofill_messages.h ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index 17ae4831fe58a5aec23fe2598aa329f18ea330f7..cb59f0742d5b5685586923337bb0fa038e01019c 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -124,6 +124,7 @@ class PasswordAutofillAgent : public content::RenderViewObserver {

// RenderView IPC handlers:

void OnFillPasswordForm(const PasswordFormFillData& form_data);

+ void OnRemoveSavedPassword();

// Scans the given frame for password forms and sends them up to the browser.

// If |only_visible| is true, only forms visible in the layout are sent.

@@ -183,6 +184,9 @@ class PasswordAutofillAgent : public content::RenderViewObserver {

// Pointer to the WebView. Used to access page scale factor.

blink::WebView* web_view_;

+ // Currently selected form

+ blink::WebFormElement current_form_;

// Set if the user might be submitting a password form on the current page,

// but the submit may still fail (i.e. doesn't pass JavaScript validation).

FrameToPasswordFormMap provisionally_saved_forms_;