components/autofill/content/common/autofill_messages.h - Issue 223133003: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 223133003: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: check Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/browser/content_autofill_driver_unittest.cc ('K') | « components/autofill/content/browser/content_autofill_driver_unittest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | components/autofill/core/browser/autofill_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 9b01b5d2a61aa6c6da003472065b0c4e092c4d6a..e2e00e994fbdf1a2a585e0bb784d6326e9082f30 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -5,6 +5,7 @@

// Multiply-included message file, hence no include guard.

#include <string>

+#include <vector>

#include "base/time/time.h"

#include "components/autofill/content/common/autofill_param_traits_macros.h"

@@ -159,6 +160,11 @@ IPC_MESSAGE_ROUTED2(AutofillMsg_RequestAutocompleteResult,

IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,

std::vector<autofill::FormData> /* forms */)

+// Instruct the renderer that a password suggestion has to be removed.

+// The renderer is going to clean the suggestions it saves and

vabr (Chromium) 2014/04/09 14:06:30 Maybe: "The renderer is going to clear the usernam

rchtara 2014/04/09 15:28:20 Done.

+// then ask the password manager to remove the password from the store.

+IPC_MESSAGE_ROUTED0(AutofillMsg_RemoveSavedPassword)

// Autofill messages sent from the renderer to the browser.

// TODO(creis): check in the browser that the renderer actually has permission

@@ -257,6 +263,10 @@ IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions,

std::vector<base::string16> /* suggestions */,

std::vector<base::string16> /* realms */)

+// Instruct the browser that a saved password has to be removed.

+IPC_MESSAGE_ROUTED1(AutofillHostMsg_RemoveSavedPasswordAndUpdateManagers,

+ autofill::PasswordForm /* the password form */)

// Inform browser of data list values for the curent field.

IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,

std::vector<base::string16> /* values */,