Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 223133003: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index a1d059589492736eed0e34e955bde29ce2f15c29..24effab78b0121356804c7a0cc520970771e246b 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -96,6 +96,11 @@ class PasswordFormManager : public PasswordStoreConsumer {
bool HasGeneratedPassword();
void SetHasGeneratedPassword();
+ void Update(
vabr (Chromium) 2014/04/04 10:51:40 This method definitely needs a comment explaining
+ const base::string16& username_to_remove,
+ const PasswordStore::AuthorizationPromptPolicy& prompt_policy,
+ bool remove_candidate_from_store);
+
// Determines if we need to autofill given the results of the query.
// Takes ownership of the elements in |result|.
void OnRequestDone(const std::vector<autofill::PasswordForm*>& result);
@@ -273,6 +278,9 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Whether this form has an auto generated password.
bool has_generated_password_;
+ bool remove_candidate_from_store_;
vabr (Chromium) 2014/04/04 10:51:40 Given my suggestions in the *.cc file, these varia
+ base::string16 username_to_remove_;
+
// Set if the user has selected one of the other possible usernames in
// |pending_credentials_|.
base::string16 selected_username_;

Powered by Google App Engine
This is Rietveld 408576698