Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/browser/content_autofill_driver_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/content/browser/content_autofill_driver.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/test_autofill_manager_delegate.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/autofill/core/common/form_data_predictions.h"
+#include "components/autofill/core/common/password_form.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "content/public/test/mock_render_process_host.h"
 #include "content/public/test/test_renderer_host.h"
 #include "ipc/ipc_test_sink.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 110 matching lines @@
     if (!AutofillMsg_FieldTypePredictionsAvailable::Read(message,
                                                          &autofill_param))
       return false;
     if (predictions)
       *predictions = autofill_param.a;
 
     process()->sink().ClearMessages();
     return true;
   }
 
+  // Searches for an |AutofillMsg_RemoveSavedPassword| message in the queue
+  // of sent IPC messages. If none is present, returns false. Otherwise,
+  // extracts the first |AutofillMsg_RemoveSavedPassword| message and returns
+  // true.
+  bool GetRemoveSavedPasswordMessage() {
+    const uint32 kMsgID = AutofillMsg_RemoveSavedPassword::ID;
+    const IPC::Message* message =
+        process()->sink().GetFirstMessageMatching(kMsgID);
+    if (!message)
+      return false;
+    process()->sink().ClearMessages();
+    return true;
+  }
+
   // Searches for a message matching |messageID| in the queue of sent IPC
   // messages. If none is present, returns false. Otherwise, extracts the first
   // matching message, fills the output parameter with the string16 from the
   // message's parameter, and clears the queue of sent messages.
   bool GetString16FromMessageWithID(uint32 messageID, base::string16* value) {
     const IPC::Message* message =
         process()->sink().GetFirstMessageMatching(messageID);
     if (!message)
       return false;
     Tuple1<base::string16> autofill_param;
@@ skipping 77 matching lines @@
 
   int output_page_id = 0;
   FormData output_form_data;
   EXPECT_FALSE(
       GetAutofillPreviewFormMessage(&output_page_id, &output_form_data));
   EXPECT_TRUE(GetAutofillFillFormMessage(&output_page_id, &output_form_data));
   EXPECT_EQ(input_page_id, output_page_id);
   EXPECT_EQ(input_form_data, output_form_data);
 }
 
+TEST_F(ContentAutofillDriverTest, RemoveSavedPasswordSentToRenderer) {
+  base::string16 input_username(base::ASCIIToUTF16("username"));
+  driver_->RemovePasswordAutofillSuggestion(input_username);
+  EXPECT_TRUE(GetRemoveSavedPasswordMessage());

[vabr (Chromium), 2014/04/09 14:06:30]

Could you please also check, that the right username was stored in the
AutofillManager?

[rchtara, 2014/04/09 15:28:20]

Done.

+}
+
 TEST_F(ContentAutofillDriverTest, FormDataSentToRenderer_PreviewForm) {
   int input_page_id = 42;
   FormData input_form_data;
   test::CreateTestAddressFormData(&input_form_data);
   driver_->SendFormDataToRenderer(
       input_page_id, AutofillDriver::FORM_DATA_ACTION_PREVIEW, input_form_data);
 
   int output_page_id = 0;
   FormData output_form_data;
   EXPECT_FALSE(GetAutofillFillFormMessage(&output_page_id, &output_form_data));
@@ skipping 72 matching lines @@
   base::string16 input_value(base::ASCIIToUTF16("barqux"));
   base::string16 output_value;
   driver_->RendererShouldPreviewFieldWithValue(input_value);
   EXPECT_TRUE(GetString16FromMessageWithID(
       AutofillMsg_PreviewFieldWithValue::ID,
       &output_value));
   EXPECT_EQ(input_value, output_value);
 }
 
 }  // namespace autofill