Allow deleting autofill password suggestions on Shift+Delete

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_manager.h"
@@ skipping 182 matching lines @@
     driver_->RendererShouldFillFieldWithValue(value);
   } else {
     FillAutofillFormData(identifier, false);
   }
 
   manager_->delegate()->HideAutofillPopup();
 }
 
 void AutofillExternalDelegate::RemoveSuggestion(const base::string16& value,
                                                 int identifier) {
-  if (identifier > 0)
+  if (identifier > 0) {
     manager_->RemoveAutofillProfileOrCreditCard(identifier);
-  else
+  } else if (identifier == POPUP_ITEM_ID_PASSWORD_ENTRY) {
+    bool success =
+        password_manager_.RemovePasswordSuggestion(query_field_, value);
+    DCHECK(success);
+  } else {

[Ilya Sherman, 2014/04/09 06:33:05]

nit: Please DCHECK that the identifier is for an autocomplete entry.

[rchtara, 2014/04/09 13:52:43]

Done.

     manager_->RemoveAutocompleteEntry(query_field_.name, value);
+  }
 }
 
 void AutofillExternalDelegate::DidEndTextFieldEditing() {
   manager_->delegate()->HideAutofillPopup();
 
   has_shown_popup_for_current_edit_ = false;
 }
 
 void AutofillExternalDelegate::ClearPreviewedForm() {
   driver_->RendererShouldClearPreviewedForm();
@@ skipping 127 matching lines @@
   // Set the values that all datalist elements share.
   icons->insert(icons->begin(),
                 data_list_values_.size(),
                 base::string16());
   unique_ids->insert(unique_ids->begin(),
                      data_list_values_.size(),
                      POPUP_ITEM_ID_DATALIST_ENTRY);
 }
 
 }  // namespace autofill