runtime/vm/service.cc - Issue 2231313002: Avoid to list internal Arrays in _GetRetainingPath api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service.cc

Issue 2231313002: Avoid to list internal Arrays in _GetRetainingPath api (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service.cc

diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc

index c57890a6b0404b44a1e447cfeb2be8747eee10b6..3e98d2fb68afa2cd9a8af54379588442cd0689f3 100644

--- a/runtime/vm/service.cc

+++ b/runtime/vm/service.cc

@@ -2011,7 +2011,6 @@ static bool PrintRetainingPath(Thread* thread,

for (intptr_t i = 0; i < limit; ++i) {

JSONObject jselement(&elements);

element = path.At(i * 2);

- jselement.AddProperty("index", i);

Cutch 2016/08/11 13:23:21 Why stop sending this?

cbernaschina 2016/08/11 22:03:31 No other api in the service protocol adds this fie

jselement.AddProperty("value", element);

// Interpret the word offset from parent as list index or instance field.

// TODO(koda): User-friendly interpretation for map entries.

« runtime/vm/object_graph.cc ('K') | « runtime/vm/object_graph.cc ('k') | no next file » | no next file with comments »