Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2231253003: [AFL] Add update script. (Closed)

Created:
4 years, 4 months ago by Jonathan Metzman
Modified:
4 years, 4 months ago
Reviewers:
Oliver Chang, aarya
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[AFL] Add update script. Add update.py for afl which does the following when executed: 1. Downloads the latest release of AFL (or the version specified by the optional argument <version>. 2. Extracts it to the proper location without extracting the files that cause presubmit and checkdeps to fail. 3. Updates the version in the README.chromium BUG=611337 Committed: https://crrev.com/7aa56b8b1878d962d9e77d00b7540e7d04033318 Cr-Commit-Position: refs/heads/master@{#411573}

Patch Set 1 #

Patch Set 2 : Add comments. #

Patch Set 3 : Alphabetize Imports #

Total comments: 3

Patch Set 4 : Add comment explaining why we use HTTP to download AFL. #

Patch Set 5 : Fix regex to remove unwanted directory from AFL. #

Patch Set 6 : Add license header. #

Patch Set 7 : Fixed README.chromium as Abhishek asked. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -8 lines) Patch
M third_party/afl/README.chromium View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
A third_party/afl/update.py View 1 2 3 4 5 1 chunk +181 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Jonathan Metzman
4 years, 4 months ago (2016-08-10 22:49:26 UTC) #2
Oliver Chang
https://codereview.chromium.org/2231253003/diff/40001/third_party/afl/update.py File third_party/afl/update.py (right): https://codereview.chromium.org/2231253003/diff/40001/third_party/afl/update.py#newcode87 third_party/afl/update.py:87: self.url = "http://lcamtuf.coredump.cx/afl/releases/{0}".format(filename) no https?
4 years, 4 months ago (2016-08-10 22:56:29 UTC) #3
Jonathan Metzman
https://codereview.chromium.org/2231253003/diff/40001/third_party/afl/update.py File third_party/afl/update.py (right): https://codereview.chromium.org/2231253003/diff/40001/third_party/afl/update.py#newcode87 third_party/afl/update.py:87: self.url = "http://lcamtuf.coredump.cx/afl/releases/{0}".format(filename) On 2016/08/10 22:56:29, Oliver Chang wrote: ...
4 years, 4 months ago (2016-08-10 22:59:43 UTC) #4
Oliver Chang
lgtm https://codereview.chromium.org/2231253003/diff/40001/third_party/afl/update.py File third_party/afl/update.py (right): https://codereview.chromium.org/2231253003/diff/40001/third_party/afl/update.py#newcode87 third_party/afl/update.py:87: self.url = "http://lcamtuf.coredump.cx/afl/releases/{0}".format(filename) On 2016/08/10 22:59:43, Jonathan Metzman ...
4 years, 4 months ago (2016-08-10 23:22:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231253003/80001
4 years, 4 months ago (2016-08-11 23:58:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/278823)
4 years, 4 months ago (2016-08-12 01:14:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231253003/120001
4 years, 4 months ago (2016-08-12 06:55:36 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 4 months ago (2016-08-12 07:28:53 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 07:30:42 UTC) #20
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7aa56b8b1878d962d9e77d00b7540e7d04033318
Cr-Commit-Position: refs/heads/master@{#411573}

Powered by Google App Engine
This is Rietveld 408576698