Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2231253002: Add the ability to dump initial recipe properties. (Closed)

Created:
4 years, 4 months ago by dnj
Modified:
4 years, 4 months ago
Reviewers:
iannucci, nodir, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org, nodir
Base URL:
https://github.com/luci/recipes-py@recipes-proto-config
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the ability to dump initial recipe properties. BUG=chromium:628770 TEST=local - Ran with this flag enabled, creates the new step and dumps initial properties. Committed: https://github.com/luci/recipes-py/commit/f50a2af3c5190b5b9780855085bd5a8df0d4ec58

Patch Set 1 #

Patch Set 2 : Rebarse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M recipe_engine/arguments.proto View 1 1 chunk +4 lines, -0 lines 0 comments Download
M recipe_engine/arguments_pb2.py View 1 4 chunks +10 lines, -3 lines 0 comments Download
M recipes.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
dnj
PTAL
4 years, 4 months ago (2016-08-10 22:43:47 UTC) #2
martiniss
lgtm Nodir, WDYT?
4 years, 4 months ago (2016-08-10 22:55:44 UTC) #4
dnj
Ping?
4 years, 4 months ago (2016-08-15 16:45:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231253002/1
4 years, 4 months ago (2016-08-15 20:52:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30a8cc0bc5ea7310)
4 years, 4 months ago (2016-08-15 20:54:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231253002/20001
4 years, 4 months ago (2016-08-16 00:40:35 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 00:45:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/f50a2af3c5190b5b9780855085bd5a8df0d...

Powered by Google App Engine
This is Rietveld 408576698