Use CheckedNumeric when converting SkIRect to gfx::Rect.

cc/output/filter_operations_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "cc/output/filter_operations.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/skia/include/core/SkXfermode.h"
 #include "third_party/skia/include/effects/SkBlurImageFilter.h"
 #include "third_party/skia/include/effects/SkDropShadowImageFilter.h"
 #include "third_party/skia/include/effects/SkOffsetImageFilter.h"
+#include "third_party/skia/include/effects/SkXfermodeImageFilter.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/rect.h"
 
 namespace cc {
 namespace {
 
 TEST(FilterOperationsTest, GetOutsetsBlur) {
   FilterOperations ops;
   ops.Append(FilterOperation::CreateBlurFilter(20));
   int top, right, bottom, left;
@@ skipping 246 matching lines @@
 
 TEST(FilterOperationsTest, MapRectReverseDropShadowDoesNotContract) {
   // Even with a drop-shadow, the original content is still drawn. Thus the
   // content bounds are never contracted due to a drop-shadow.
   FilterOperations ops;
   ops.Append(FilterOperation::CreateDropShadowFilter(gfx::Point(3, 8), 0, 0));
   EXPECT_EQ(gfx::Rect(-3, -8, 13, 18),
             ops.MapRectReverse(gfx::Rect(0, 0, 10, 10), SkMatrix::I()));
 }
 
+TEST(FilterOperationsTest, MapRectTypeConversionDoesNotOverflow) {
+  // Must be bigger than half of the positive range so that the width/height
+  // overflow happens, but small enough that there aren't other issues before
+  // the overflow would happen.
+  SkScalar big_offset =
+      SkFloatToScalar(std::numeric_limits<int>::max()) * 2 / 3;
+
+  FilterOperations ops;
+  ops.Append(FilterOperation::CreateReferenceFilter(SkXfermodeImageFilter::Make(
+      SkXfermode::Make(SkXfermode::kSrcOver_Mode),
+      SkOffsetImageFilter::Make(-big_offset, -big_offset, nullptr),
+      SkOffsetImageFilter::Make(big_offset, big_offset, nullptr), nullptr)));
+  gfx::Rect rect = ops.MapRect(gfx::Rect(-10, -10, 20, 20), SkMatrix::I());
+  EXPECT_GT(rect.width(), 0);
+  EXPECT_GT(rect.height(), 0);
+}
+
 #define SAVE_RESTORE_AMOUNT(filter_name, filter_type, a)                  \
   {                                                                       \
     FilterOperation op = FilterOperation::Create##filter_name##Filter(a); \
     EXPECT_EQ(FilterOperation::filter_type, op.type());                   \
     EXPECT_EQ(a, op.amount());                                            \
                                                                           \
     FilterOperation op2 = FilterOperation::CreateEmptyFilter();           \
     op2.set_type(FilterOperation::filter_type);                           \
                                                                           \
     EXPECT_NE(a, op2.amount());                                           \
@@ skipping 645 matching lines @@
   blended = to.Blend(from, -0.75);
   EXPECT_EQ(to, blended);
   blended = to.Blend(from, 0.75);
   EXPECT_EQ(to, blended);
   blended = to.Blend(from, 1.5);
   EXPECT_EQ(to, blended);
 }
 
 }  // namespace
 }  // namespace cc