Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2231233002: cc: Remove the lie of "DirectRenderer" in LayerTreeTests. (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove the lie of "DirectRenderer" in LayerTreeTests. The bool for "delegating_renderer" was still there but unusued. Remove it along with the DIRECT_RENDERER macros, and any test variants that were explicitly setting delegating_renderer to false when there was another variant setting it to true. R=enne, vmpstr BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/0943a11e58828e6f94286431b1cd7bdd968f152f Cr-Commit-Position: refs/heads/master@{#411205}

Patch Set 1 #

Patch Set 2 : no-ltt-delegating: ccpt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -162 lines) Patch
M cc/layers/scrollbar_layer_unittest.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.h View 4 chunks +3 lines, -21 lines 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common_perftest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 13 chunks +18 lines, -30 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 2 chunks +14 lines, -59 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
danakj
4 years, 4 months ago (2016-08-10 20:44:51 UTC) #3
vmpstr
lgtm
4 years, 4 months ago (2016-08-10 20:49:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231233002/1
4 years, 4 months ago (2016-08-10 20:55:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/138673) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 21:09:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231233002/20001
4 years, 4 months ago (2016-08-10 21:27:50 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 00:34:03 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 00:36:07 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0943a11e58828e6f94286431b1cd7bdd968f152f
Cr-Commit-Position: refs/heads/master@{#411205}

Powered by Google App Engine
This is Rietveld 408576698