Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 223123003: Make DevTools support for the embedded SharedWorker. (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 8 months ago
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman, kinuko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make DevTools support for the embedded SharedWorker. Original patch is https://codereview.chromium.org/196503005/. But it was reverted because of memory leaks. https://codereview.chromium.org/223583002/ This is the fixed version. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261432

Patch Set 1 : original patch 196503005 #

Patch Set 2 : fixed version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+794 lines, -49 lines) Patch
A content/browser/devtools/shared_worker_devtools_manager.h View 1 chunk +95 lines, -0 lines 0 comments Download
A content/browser/devtools/shared_worker_devtools_manager.cc View 1 1 chunk +250 lines, -0 lines 0 comments Download
A content/browser/devtools/shared_worker_devtools_manager_unittest.cc View 1 chunk +263 lines, -0 lines 0 comments Download
M content/browser/devtools/worker_devtools_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/worker_devtools_manager.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 5 chunks +34 lines, -10 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 3 chunks +12 lines, -5 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 7 chunks +84 lines, -16 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl_unittest.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
horo
jochen@ Could you please review this? The difference from the original patch 196503005 is "else ...
6 years, 8 months ago (2014-04-03 09:20:39 UTC) #1
yurys
lgtm
6 years, 8 months ago (2014-04-03 10:58:40 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-03 13:11:03 UTC) #3
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-03 13:44:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/223123003/20001
6 years, 8 months ago (2014-04-03 13:44:11 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 16:06:50 UTC) #6
Message was sent while issue was closed. 
Change committed as 261432

Powered by Google App Engine
This is Rietveld 408576698