Settings Router Refactor: Normalize URL only for main settings page.

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 283 matching lines @@
   var getRouteForPath = function(path) {
     // TODO(tommycli): Use Object.values once Closure compilation supports it.
     var matchingKey = Object.keys(Route).find(function(key) {
       return Route[key].path == path;
     });
 
     return Route[matchingKey] || null;
   };
 
   /**
    * The current active route. This updated only by settings.navigateTo.

[michaelpg, 2016/08/12 22:18:02]

"is updated"

"or initializeRouteFromURL"?

[tommycli, 2016/08/15 17:36:00]

Done.

    * @private {!settings.Route}
    */
   var currentRoute_ = Route.BASIC;
 
   /**
    * The current query parameters. This updated only by settings.navigateTo.

[michaelpg, 2016/08/12 22:18:02]

same

[tommycli, 2016/08/15 17:36:00]

Done.

    * @private {!URLSearchParams}
    */
   var currentQueryParameters_ = new URLSearchParams();
 
-  // Initialize the route and query params from the URL.
-  (function() {
+  /**
+   * Initialize the route and query params from the URL.
+   */
+  var initializeRouteFromUrl = function() {
     var route = getRouteForPath(window.location.pathname);

[michaelpg, 2016/08/12 22:18:02]

wonder if it's worth adding a check that we only call this once.

[tommycli, 2016/08/15 17:36:00]

Done.

     if (route) {
       currentRoute_ = route;
       currentQueryParameters_ = new URLSearchParams(window.location.search);
     } else {
-      window.history.pushState(undefined, '', Route.BASIC.path);
+      window.history.replaceState(undefined, '', Route.BASIC.path);
     }
-  })();
+  };
 
   /**
    * Helper function to set the current route and notify all observers.
    * @param {!settings.Route} route
    * @param {!URLSearchParams} queryParameters
    */
   var setCurrentRoute = function(route, queryParameters) {
     var oldRoute = currentRoute_;
     currentRoute_ = route;
     currentQueryParameters_ = queryParameters;
@@ skipping 37 matching lines @@
   window.addEventListener('popstate', function(event) {
     // On pop state, do not push the state onto the window.history again.
     setCurrentRoute(getRouteForPath(window.location.pathname) || Route.BASIC,
                     new URLSearchParams(window.location.search));
   });
 
   return {
     Route: Route,
     RouteObserverBehavior: RouteObserverBehavior,
     getRouteForPath: getRouteForPath,
+    initializeRouteFromUrl: initializeRouteFromUrl,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     navigateTo: navigateTo,
   };
 });