Settings Router Refactor: Normalize URL only for main settings page.

Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/67d17aee41b895d81c6e6e7d7ff33690bee9f74e
Cr-Commit-Position: refs/heads/master@{#411995}

[tommycli, 2016-08-10 19:23:59]

Description was changed from

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

BUG=632382
==========

to

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-10 19:24:15]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 19:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-10 19:25:23]

Description was changed from

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-10 19:25:24]

tommycli@chromium.org changed reviewers:
+ michaelpg@chromium.org

[tommycli, 2016-08-10 20:39:34]

michaelpg: PTAL, thanks!

[commit-bot: I haz the power, 2016-08-10 21:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:26:48]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-08-11 23:34:17]

On 2016/08/10 20:39:34, tommycli wrote:
> michaelpg: PTAL, thanks!

michaelpg: ping, thx!

[michaelpg, 2016-08-12 22:18:02]

lgtm

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:304: * The current active route. This
updated only by settings.navigateTo.
"is updated"

"or initializeRouteFromURL"?

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:310: * The current query parameters.
This updated only by settings.navigateTo.
same

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:319: var route =
getRouteForPath(window.location.pathname);
wonder if it's worth adding a check that we only call this once.

[tommycli, 2016-08-15 17:36:00]

thanks!

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:304: * The current active route. This
updated only by settings.navigateTo.
On 2016/08/12 22:18:02, michaelpg wrote:
> "is updated"
> 
> "or initializeRouteFromURL"?

Done.

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:310: * The current query parameters.
This updated only by settings.navigateTo.
On 2016/08/12 22:18:02, michaelpg wrote:
> same

Done.

https://codereview.chromium.org/2231203002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:319: var route =
getRouteForPath(window.location.pathname);
On 2016/08/12 22:18:02, michaelpg wrote:
> wonder if it's worth adding a check that we only call this once.

Done.

[tommycli, 2016-08-15 17:36:03]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-15 17:36:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2231203002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-08-15 17:36:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 18:35:00]

Description was changed from

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe
Cr-Commit-Position: refs/heads/master@{#411993}
==========

[commit-bot: I haz the power, 2016-08-15 18:35:00]

Description was changed from

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe
Cr-Commit-Position: refs/heads/master@{#411993}
==========

to

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-15 18:35:01]

Patchset 2 (id:??) landed as
https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe
Cr-Commit-Position: refs/heads/master@{#411993}

[commit-bot: I haz the power, 2016-08-15 18:35:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-15 18:37:32]

Description was changed from

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ce37c93fb3538e1ebe6b84fcf370871c50401ebe
Cr-Commit-Position: refs/heads/master@{#411993}
==========

to

==========
Settings Router Refactor: Normalize URL only for main settings page.

Normalize URL in cr-settings.created only, not when child elements are
directly loaded.

i.e., URL normalized for chrome://md-settings/foo/bar but not for
chrome://md-settings/people_page/people_page.html

Also fixes a bug where the URL state is pushed rather than replaced.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/67d17aee41b895d81c6e6e7d7ff33690bee9f74e
Cr-Commit-Position: refs/heads/master@{#411995}
==========

[commit-bot: I haz the power, 2016-08-15 18:37:33]

Patchset 2 (id:??) landed as
https://crrev.com/67d17aee41b895d81c6e6e7d7ff33690bee9f74e
Cr-Commit-Position: refs/heads/master@{#411995}