Issue 22312006: findFirstGrammarDetail doesn't need to be exposed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22312006: findFirstGrammarDetail doesn't need to be exposed (Closed)

Created:
7 years, 4 months ago by grzegorz

Modified:
7 years, 4 months ago

Reviewers:
Hajime Morrita, tony

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

findFirstGrammarDetail doesn't need to be exposed Make TextCheckingHelper::findFirstGrammarDetail private. Additionaly, remove badGrammarPhraseLength param, it's not used any longer and add mising const modifier. WebKit merge r153512. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155716

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/core/editing/TextCheckingHelper.h	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	Source/core/editing/TextCheckingHelper.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

grzegorz

I did check the layout tests on Linux, all tests ran as expected with this ...

7 years, 4 months ago (2013-08-07 13:01:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/22312006/1

7 years, 4 months ago (2013-08-07 19:24:37 UTC) #5

Message was sent while issue was closed.

Change committed as 155716

Expand Messages | Collapse Messages