chrome/browser/resources/settings/languages_page/languages_page.html - Issue 2231153002: MD Settings: Checks the event target in the language tap event handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2231153002: MD Settings: Checks the event target in the language tap event handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment, added test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | chrome/browser/resources/settings/languages_page/languages_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.html

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html

index 040a5eb2bb1a799015d175bdc0a058e4cf1b2d1c..baae123b0530373de2d873ed754c5e2acd3b2292 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.html

+++ b/chrome/browser/resources/settings/languages_page/languages_page.html

@@ -78,7 +78,7 @@

</div>

</if>

<paper-icon-button id="more-[[item.language.code]]"

- icon="cr:more-vert" toggles

+ icon="cr:more-vert" toggles class="dropdown-trigger"

active="{{item.optionsMenuOpened}}">

Dan Beam 2016/08/10 20:45:26 can't we just make an on-tap=methodThatCallsEventS

Moe 2016/08/10 23:58:32 the event could originate from either of dropdown-

Dan Beam 2016/08/12 01:43:43 could you put the <iron-dropdown> in the <paper-ic

Moe 2016/08/12 16:46:53 I tried, but couldn't get the dropdown to show :(

</paper-icon-button>

<iron-dropdown opened="{{item.optionsMenuOpened}}"