Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5745)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2231153002: MD Settings: Checks the event target in the language tap event handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index d88a859349c5fb9a27f7158565ba51ab9dc59325..f36e18a738a5f5716cc606a2b77f64028616e1a4 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -56,7 +56,7 @@ Polymer({
/**
* Handler for clicking a language on the main page, which selects the
* language as the prospective UI language on Chrome OS and Windows.
- * @param {!{model: !{item: !LanguageState}}} e
+ * @param {!Event} e The tap event.
*/
onLanguageTap_: function(e) {
// Only change the UI language on platforms that allow it.
@@ -64,8 +64,19 @@ Polymer({
return;
// Set the prospective UI language. This won't take effect until a restart.
- if (e.model.item.language.supportsUI)
- this.languageHelper_.setUILanguage(e.model.item.language.code);
+ var tapEvent = /** @type {!{model: !{item: !LanguageState}}} */(e);
+ if (tapEvent.model.item.language.supportsUI)
+ this.languageHelper_.setUILanguage(tapEvent.model.item.language.code);
+ },
+
+ /**
+ * Stops tap events on the language options menu, its trigger, or its items
+ * from bubbling up to the language itself. Tap events on the language are
+ * handled in onLanguageTap_.
+ * @param {!Event} e The tap event.
+ */
+ stopPropagationHandler_: function(e) {
+ e.stopPropagation();
},
/**

Powered by Google App Engine
This is Rietveld 408576698