Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7393)

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2231153002: MD Settings: Checks the event target in the language tap event handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/languages_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js
index e327fcd18525fcac8e9392f75bbd8ebda6a16fce..d765d2eb958a24d99f3f85a78f927b3321ac36da 100644
--- a/chrome/test/data/webui/settings/languages_page_browsertest.js
+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js
@@ -54,6 +54,7 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
var languagesSection;
var languagesPage;
+ var languageHelper;
suiteSetup(function() {
advanced.set('pageVisibility.languages', true);
Polymer.dom.flush();
@@ -63,7 +64,8 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
languagesPage = languagesSection.querySelector('settings-languages-page');
assertTrue(!!languagesPage);
- return LanguageHelperImpl.getInstance().whenReady();
+ languageHelper = LanguageHelperImpl.getInstance();
+ return languageHelper.whenReady();
}.bind(this));
teardown(function(done) {
@@ -84,6 +86,18 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
assertTrue(!!languagesPage.$$('settings-manage-languages-page'));
});
+ test('Should not set UI language', function() {
+ var languagesCollapse = languagesPage.$.languagesCollapse;
+ var languageOptionsDropdownTrigger = languagesCollapse.querySelector(
+ '.dropdown-trigger');
+ assertTrue(!!languageOptionsDropdownTrigger);
+
+ // This shouldn't get called.
+ languageHelper.setUILanguage = assertNotReached;
+
+ MockInteractions.tap(languageOptionsDropdownTrigger);
+ });
+
test('language detail', function() {
var languagesCollapse = languagesPage.$.languagesCollapse;
var languageDetailMenuItem = languagesCollapse.querySelectorAll(

Powered by Google App Engine
This is Rietveld 408576698