Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2231153002: MD Settings: Checks the event target in the language tap event handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/assert.html"> 1 <link rel="import" href="chrome://resources/html/assert.html">
2 <link rel="import" href="chrome://resources/html/cr.html"> 2 <link rel="import" href="chrome://resources/html/cr.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">
9 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> 9 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">
10 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 10 <link rel="import" href="chrome://resources/cr_elements/icons.html">
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 <a href="$i18n{languagesLearnMoreURL}" target="_blank"> 55 <a href="$i18n{languagesLearnMoreURL}" target="_blank">
56 $i18n{learnMore} 56 $i18n{learnMore}
57 </a> 57 </a>
58 </span> 58 </span>
59 <template is="dom-repeat" items="[[languages.enabled]]"> 59 <template is="dom-repeat" items="[[languages.enabled]]">
60 <div class$="list-item [[getLanguageItemClass_( 60 <div class$="list-item [[getLanguageItemClass_(
61 item.language.code, prefs.intl.app_locale.value, 61 item.language.code, prefs.intl.app_locale.value,
62 item.language.supportsUI)]]" 62 item.language.supportsUI)]]"
63 on-tap="onLanguageTap_"> 63 on-tap="onLanguageTap_">
64 <if expr="not chromeos and not is_win"> 64 <if expr="not chromeos and not is_win">
65 <div class="start" title="[[item.language.nativeDisplayName]]"> 65 <div class="start" title="[[item.language.nativeDisplayName]]">
Dan Beam 2016/08/11 00:09:51 can we just move the on-tap to here?
66 [[item.language.displayName]] 66 [[item.language.displayName]]
67 </div> 67 </div>
68 </if> 68 </if>
69 <if expr="chromeos or is_win"> 69 <if expr="chromeos or is_win">
70 <div title="[[item.language.nativeDisplayName]]"> 70 <div title="[[item.language.nativeDisplayName]]">
71 [[item.language.displayName]] 71 [[item.language.displayName]]
72 </div> 72 </div>
73 <div class="middle"> 73 <div class="middle">
74 <iron-icon icon="settings:done" 74 <iron-icon icon="settings:done"
75 hidden$="[[!isProspectiveUILanguage_( 75 hidden$="[[!isProspectiveUILanguage_(
76 item.language.code, prefs.intl.app_locale.value)]]"> 76 item.language.code, prefs.intl.app_locale.value)]]">
77 </iron-icon> 77 </iron-icon>
78 </div> 78 </div>
Dan Beam 2016/08/11 00:09:51 i don't reallly care that much if tapping/clicking
Moe 2016/08/11 14:41:53 Let's have a wrapper around title and .middle. Oth
79 </if> 79 </if>
80 <paper-icon-button id="more-[[item.language.code]]" 80 <paper-icon-button id="more-[[item.language.code]]"
81 icon="cr:more-vert" toggles 81 icon="cr:more-vert" toggles class="dropdown-trigger"
82 active="{{item.optionsMenuOpened}}"> 82 active="{{item.optionsMenuOpened}}">
83 </paper-icon-button> 83 </paper-icon-button>
84 <iron-dropdown opened="{{item.optionsMenuOpened}}" 84 <iron-dropdown opened="{{item.optionsMenuOpened}}"
85 horizontal-align="right" vertical-align="auto"> 85 horizontal-align="right" vertical-align="auto">
86 <div class="dropdown-content"> 86 <div class="dropdown-content">
87 <button class="dropdown-item" role="option" 87 <button class="dropdown-item" role="option"
88 on-tap="onMoveUpTap_" 88 on-tap="onMoveUpTap_"
89 hidden="[[isFirstLanguage_(index, 89 hidden="[[isFirstLanguage_(index,
90 languages.enabled.*)]]"> 90 languages.enabled.*)]]">
91 $i18n{moveUp} 91 $i18n{moveUp}
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 associated-control="[[$$('#spellcheck-subpage-trigger')]]" 217 associated-control="[[$$('#spellcheck-subpage-trigger')]]"
218 page-title="$i18n{editDictionaryPageTitle}"> 218 page-title="$i18n{editDictionaryPageTitle}">
219 <settings-edit-dictionary-page></settings-edit-dictionary-page> 219 <settings-edit-dictionary-page></settings-edit-dictionary-page>
220 </settings-subpage> 220 </settings-subpage>
221 </template> 221 </template>
222 </if> 222 </if>
223 </settings-animated-pages> 223 </settings-animated-pages>
224 </template> 224 </template>
225 <script src="languages_page.js"></script> 225 <script src="languages_page.js"></script>
226 </dom-module> 226 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698