Cleanup: fix some CSS comment styles (especially copyrights)

Cleanup: fix some CSS comment styles (especially copyrights)

TBR=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f2ac2d3d23c835435c38211af9fe696796e48526
Cr-Commit-Position: refs/heads/master@{#411539}

[Dan Beam, 2016-08-10 17:03:47]

Description was changed from

==========
Cleanup: fix some CSS comment styles (especially copyrights)

R=michaelpg@chromium.org
BUG=none
==========

to

==========
Cleanup: fix some CSS comment styles (especially copyrights)

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-08-10 17:04:50]

you're welcome!

[mmenke, 2016-08-10 17:06:08]

Description was changed from

==========
Cleanup: fix some CSS comment styles (especially copyrights)

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Cleanup: fix some CSS comment styles (especially copyrights)

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-08-10 17:22:59]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 17:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:40:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[michaelpg, 2016-08-10 19:07:38]

i think 50% of this CL will be obsolete soon.

[Dan Beam, 2016-08-10 19:41:17]

On 2016/08/10 19:07:38, michaelpg wrote:
> i think 50% of this CL will be obsolete soon.

that's OK!  it's 100% showing up in my grep now!

[Dan Beam, 2016-08-11 06:11:34]

Description was changed from

==========
Cleanup: fix some CSS comment styles (especially copyrights)

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Cleanup: fix some CSS comment styles (especially copyrights)

TBR=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-08-11 06:11:41]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-08-11 06:11:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 06:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 06:20:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[michaelpg, 2016-08-11 08:08:13]

/* where did this convention come from? is there a bug
 * or email thread expressing rationale and support? */

https://codereview.chromium.org/2231143002/diff/1/ui/webui/resources/css/widg...
File ui/webui/resources/css/widgets.css (right):

https://codereview.chromium.org/2231143002/diff/1/ui/webui/resources/css/widg...
ui/webui/resources/css/widgets.css:255: *   </div> */
putting code next to code really doesn't seem good to me.

[Dan Beam, 2016-08-12 00:31:29]

On 2016/08/11 08:08:13, michaelpg wrote:
> /* where did this convention come from? is there a bug
>  * or email thread expressing rationale and support? */

yes, there was an email thread, but it's over 18 months old

https://codereview.chromium.org/2231143002/diff/1/ui/webui/resources/css/widg...
File ui/webui/resources/css/widgets.css (right):

https://codereview.chromium.org/2231143002/diff/1/ui/webui/resources/css/widg...
ui/webui/resources/css/widgets.css:255: *   </div> */
On 2016/08/11 08:08:13, michaelpg wrote:
> putting code next to code really doesn't seem good to me.

fine, reverted

[Dan Beam, 2016-08-12 00:41:02]

On 2016/08/11 08:08:13, michaelpg wrote:
> /* where did this convention come from? is there a bug
>  * or email thread expressing rationale and support? */

additionally, consistency of code IS rationale that's very prominent in the
style guide[1]:

"""
Parting Words

Be consistent.

If you’re editing code, take a few minutes to look at the code around you and
determine its style. If they use spaces around all their arithmetic operators,
you should too. If their comments have little boxes of hash marks around them,
make your comments have little boxes of hash marks around them too.

The point of having style guidelines is to have a common vocabulary of coding so
people can concentrate on what you’re saying rather than on how you’re saying
it. We present global style rules here so people know the vocabulary, but local
style is also important. If code you add to a file looks drastically different
from the existing code around it, it throws readers out of their rhythm when
they go to read it. Avoid this.
"""

using codesearch through the files that I own / am changing, */$ is used twice
as often as \n*/.  once this lands, it'll be much more consistent, making it
easier for folks to think less about how this should look.

code searches:
file:(ui/webui|chrome/browser/resources).*\.css$
^\s\*\sfound\sin\sthe\sLICENSE\sfile.\s\*\/$
file:(ui/webui|chrome/browser/resources).*\.css$
^\s\*\sfound\sin\sthe\sLICENSE\sfile.$

[1] https://google.github.io/styleguide/htmlcssguide.xml#Comments

[Dan Beam, 2016-08-12 00:41:39]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 00:42:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 02:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 02:34:10]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-08-12 03:17:42]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-08-12 03:18:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 03:24:44]

Description was changed from

==========
Cleanup: fix some CSS comment styles (especially copyrights)

TBR=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Cleanup: fix some CSS comment styles (especially copyrights)

TBR=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-12 03:24:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 03:27:26]

Description was changed from

==========
Cleanup: fix some CSS comment styles (especially copyrights)

TBR=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Cleanup: fix some CSS comment styles (especially copyrights)

TBR=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f2ac2d3d23c835435c38211af9fe696796e48526
Cr-Commit-Position: refs/heads/master@{#411539}
==========

[commit-bot: I haz the power, 2016-08-12 03:27:29]

Patchset 2 (id:??) landed as
https://crrev.com/f2ac2d3d23c835435c38211af9fe696796e48526
Cr-Commit-Position: refs/heads/master@{#411539}

[michaelpg, 2016-08-12 05:45:38]

rslgtm