Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2231133002: Revert of Eliminate kMojoChannelToken usage for render processes (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Eliminate kMojoChannelToken usage for render processes (patchset #6 id:100001 of https://codereview.chromium.org/2201183005/ ) Reason for revert: Speculative revert for failures on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29 - can't repro locally but wanna see if this greens the tests. Original issue's description: > Eliminate kMojoChannelToken usage for render processes > > Changes RenderProcessHostImpl to connect its IPC Channel > by requesting a nominal IPC::mojom::ChannelBootstrap > interface from its shell::Connection to the render process. > > Changes ChildThreadImpl to support binding such requests > by fusing them to its local IPC Channel if the (now deprecated) > kMojoChannelToken was not provided. > > BUG=623396 > R=ben@chromium.org > > Committed: https://crrev.com/7a7f8f7e6977500d09270ff9d9b3817dda5e5b8a > Committed: https://crrev.com/ff1b853cb6bfc3d5402fc970b2d856cbe73418cc > Cr-Original-Commit-Position: refs/heads/master@{#410656} > Cr-Commit-Position: refs/heads/master@{#410699} TBR=ben@chromium.org,huangs@chromium.org,jschuh@chromium.org,tsepez@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -193 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +14 lines, -8 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 6 chunks +71 lines, -114 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 6 chunks +7 lines, -57 lines 0 comments Download
M ipc/ipc.mojom View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Ken Rockot(use gerrit already)
Created Revert of Eliminate kMojoChannelToken usage for render processes
4 years, 4 months ago (2016-08-10 17:01:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231133002/1
4 years, 4 months ago (2016-08-10 17:02:29 UTC) #3
Tom Sepez
RS LGTM
4 years, 4 months ago (2016-08-10 17:11:22 UTC) #4
Tom Sepez
RS LGTM
4 years, 4 months ago (2016-08-10 17:11:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120016)
4 years, 4 months ago (2016-08-10 18:41:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231133002/1
4 years, 4 months ago (2016-08-10 18:49:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120077)
4 years, 4 months ago (2016-08-10 21:22:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231133002/1
4 years, 4 months ago (2016-08-10 23:58:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/235533)
4 years, 4 months ago (2016-08-11 00:06:28 UTC) #15
Ken Rockot(use gerrit already)
4 years, 4 months ago (2016-08-11 00:35:09 UTC) #16
Actually I'm not going to revert this. The Win breakage is unfortunate but
clearly not a blocker. I will submit a separate CL which reverts only RPHI
behavior to green the bot while I'm OOO.

Powered by Google App Engine
This is Rietveld 408576698