Issue 2231123002: Retry: Fixes memory leaks in the eventhandler

Issue 2231123002: Retry: Fixes memory leaks in the eventhandler (Closed)

Created:
4 years, 4 months ago by zra

Modified:
4 years, 4 months ago

Reviewers:
Søren Gjesse, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Retry: Fixes memory leaks in the eventhandler Crashes were caused by removing from a std::map while iterating over it. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/581939d8b6b1ea8cfc50c88fe06761b99f5c2e37

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -96 lines)			Patch
M	runtime/bin/eventhandler.h	View		7 chunks	+19 lines, -5 lines	0 comments	Download
M	runtime/bin/eventhandler_android.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/bin/socket.h	View	1 2	4 chunks	+58 lines, -33 lines	0 comments	Download
M	runtime/bin/socket.cc	View	1	5 chunks	+106 lines, -44 lines	0 comments	Download
M	runtime/platform/hashmap.h	View	1	4 chunks	+16 lines, -9 lines	0 comments	Download
M	runtime/platform/hashmap.cc	View		4 chunks	+10 lines, -5 lines	0 comments	Download

Total messages: 6 (2 generated)

zra

Committed patchset #3 (id:40001) manually as 581939d8b6b1ea8cfc50c88fe06761b99f5c2e37 (presubmit successful).

4 years, 4 months ago (2016-08-10 22:20:35 UTC) #5

Message was sent while issue was closed.

lgtm