Issue 2231073002: Change SDK builder bot to use sysroots when compiling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2231073002: Change SDK builder bot to use sysroots when compiling (Closed)

Created:
4 years, 4 months ago by Bill Hesse

Modified:
4 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Change SDK builder bot to use sysroots when compiling BUG=https://github.com/dart-lang/sdk/issues/27048 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/81f22262256848b7e8430794d34300fa9ee19472

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
	M	tools/bots/bot.py	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	tools/bots/dart_sdk.py	View		3 chunks	+20 lines, -3 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

Committed patchset #1 (id:1) manually as 81f22262256848b7e8430794d34300fa9ee19472 (presubmit successful).

4 years, 4 months ago (2016-08-10 15:28:27 UTC) #4

Bill Hesse

4 years, 4 months ago (2016-08-10 15:34:06 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/2231073002/diff/1/tools/bots/dart_sdk.py
File tools/bots/dart_sdk.py (right):

https://codereview.chromium.org/2231073002/diff/1/tools/bots/dart_sdk.py#newc...
tools/bots/dart_sdk.py:33: '--arch=ia32', 'create_sdk'], env=sysroot)
This should have been env=sysroot_env

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages