Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2231003002: Revert of Show small notification icons in notification tray (Closed)

Created:
4 years, 4 months ago by huangs
Modified:
4 years, 4 months ago
Reviewers:
xiyuan, yoshiki, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show small notification icons in notification tray (patchset #5 id:260001 of https://codereview.chromium.org/2209443006/ ) Reason for revert: Suspecting this CL of causing ASAN failure, from memory leak: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15200 Original issue's description: > Show small notification icons in notification tray > > This patch shows small notification icons (up to 3) of the > current notifications in the notification tray. > > This also makes the counter show the count of all the > notification excluding the visible small icons (previously > it was the unread count). > > See the issue for screenshots. > > BUG=633399 > TEST=manual test (with and without MD mode) > > Committed: https://crrev.com/42754bb876e40c0c87ed63607452026190e13f78 > Cr-Commit-Position: refs/heads/master@{#411019} TBR=oshima@chromium.org,xiyuan@chromium.org,yoshiki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633399 Committed: https://crrev.com/62e692763e4be7b6c7858395f0d7bb8d29b141f1 Cr-Commit-Position: refs/heads/master@{#411033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -273 lines) Patch
M ash/common/system/tray/tray_background_view.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ash/common/system/web_notification/web_notification_tray.h View 5 chunks +3 lines, -14 lines 0 comments Download
M ash/common/system/web_notification/web_notification_tray.cc View 10 chunks +70 lines, -234 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
huangs
Created Revert of Show small notification icons in notification tray
4 years, 4 months ago (2016-08-10 13:46:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231003002/1
4 years, 4 months ago (2016-08-10 13:46:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 13:47:25 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 13:48:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62e692763e4be7b6c7858395f0d7bb8d29b141f1
Cr-Commit-Position: refs/heads/master@{#411033}

Powered by Google App Engine
This is Rietveld 408576698