Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 2230993004: [DevTools] Recognize node remote target type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Redid to use target attribute Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index a32b4c95be78d3a3d3849e5eacf72a46ca314504..c7e552e22e3e829749aec6f79fdda2d16a3bcb14 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -103,7 +103,8 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
Profile* profile,
const std::string& frontend_uri,
const scoped_refptr<content::DevToolsAgentHost>& agent_host,
- bool isWorker);
+ bool isWorker,
dgozman 2016/08/10 23:13:43 Please change these to is_worker and is_v8_only.
eostroukhov 2016/08/10 23:31:08 Done.
+ bool isV8);
// Worker frontend is always undocked.
static void OpenDevToolsWindowForWorker(
@@ -247,12 +248,14 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
const GURL& frontend_url,
content::WebContents* inspected_web_contents,
bool shared_worker_frontend,
+ bool v8_frontend,
dgozman 2016/08/10 23:13:43 v8_only_frontend
eostroukhov 2016/08/10 23:31:07 Done.
const std::string& remote_frontend,
bool can_dock,
const std::string& settings);
static GURL GetDevToolsURL(Profile* profile,
const GURL& base_url,
bool shared_worker_frontend,
+ bool v8_frontend,
const std::string& remote_frontend,
bool can_dock);

Powered by Google App Engine
This is Rietveld 408576698