Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.cc

Issue 2230993004: [DevTools] Recognize node remote target type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Redid to use target attribute Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/devtools_android_bridge.cc
diff --git a/chrome/browser/devtools/device/devtools_android_bridge.cc b/chrome/browser/devtools/device/devtools_android_bridge.cc
index 8593912a31dec51e414023e46efc1738e942c7b0..35bc8282d0d21a068f976ea840320c0f8f328ab3 100644
--- a/chrome/browser/devtools/device/devtools_android_bridge.cc
+++ b/chrome/browser/devtools/device/devtools_android_bridge.cc
@@ -529,8 +529,9 @@ void DevToolsAndroidBridge::RemotePageTarget::Inspect(Profile* profile) const {
Activate();
bool isWorker = remote_type_ == kTargetTypeWorker ||
dgozman 2016/08/10 23:13:43 Please change these to is_worker and is_v8_only.
eostroukhov 2016/08/10 23:31:07 Done.
remote_type_ == kTargetTypeServiceWorker;
+ bool isV8 = remote_type_ == kTargetTypeNode;
DevToolsWindow::OpenExternalFrontend(profile, frontend_url_, GetAgentHost(),
- isWorker);
+ isWorker, isV8);
}
bool DevToolsAndroidBridge::RemotePageTarget::Activate() const {
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_target_impl.h » ('j') | chrome/browser/devtools/devtools_window.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698