third_party/WebKit/Source/core/page/ChromeClient.h - Issue 2230993002: Refactor composited selection code out of WebViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/ChromeClient.h

Issue 2230993002: Refactor composited selection code out of WebViewImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use single localFrame clearing. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/page/ChromeClient.h

diff --git a/third_party/WebKit/Source/core/page/ChromeClient.h b/third_party/WebKit/Source/core/page/ChromeClient.h

index 762d7844a784f046c7bdad2895f671c6c6d7b628..fd6513695f5ebe8142d286253b27bb102d868311 100644

--- a/third_party/WebKit/Source/core/page/ChromeClient.h

+++ b/third_party/WebKit/Source/core/page/ChromeClient.h

@@ -211,8 +211,8 @@ public:

virtual void enterFullScreenForElement(Element*) { }

virtual void exitFullScreenForElement(Element*) { }

- virtual void clearCompositedSelection() { }

- virtual void updateCompositedSelection(const CompositedSelection&) { }

+ virtual void clearCompositedSelection(LocalFrame*) { }

+ virtual void updateCompositedSelection(LocalFrame*, const CompositedSelection&) { }

virtual void setEventListenerProperties(WebEventListenerClass, WebEventListenerProperties) = 0;

virtual WebEventListenerProperties eventListenerProperties(WebEventListenerClass) const = 0;

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | no next file with comments »