Refactor composited selection code out of WebViewImpl.

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 807 matching lines @@
 void ChromeClientImpl::enterFullScreenForElement(Element* element)
 {
     m_webView->enterFullScreenForElement(element);
 }
 
 void ChromeClientImpl::exitFullScreenForElement(Element* element)
 {
     m_webView->exitFullScreenForElement(element);
 }
 
-void ChromeClientImpl::clearCompositedSelection()
+void ChromeClientImpl::clearCompositedSelection(LocalFrame* frame)
 {
-    m_webView->clearCompositedSelection();
+    LocalFrame* localRoot = frame->localFrameRoot();
+    auto client = WebLocalFrameImpl::fromFrame(localRoot)->frameWidget()->client();

[bokan, 2016/08/11 14:14:06]

I don't think `auto` helps in these cases. My read on Chromium policy is that,
while not explicitly disallowed for these cases, we should be judicious with
auto - mainly limited to range for loops and template types where the type is
just boiler plate. Please just use the real types.

[wjmaclean, 2016/08/11 14:35:06]

Done.

+    if (!client)
+        return;
+
+    auto layerTreeView = client->layerTreeView();
+    if (layerTreeView)
+        layerTreeView->clearSelection();
 }
 
-void ChromeClientImpl::updateCompositedSelection(const CompositedSelection& selection)
+void ChromeClientImpl::updateCompositedSelection(LocalFrame* frame, const CompositedSelection& selection)
 {
-    m_webView->updateCompositedSelection(WebSelection(selection));
+    LocalFrame* localRoot = frame->localFrameRoot();
+    auto client = WebLocalFrameImpl::fromFrame(localRoot)->frameWidget()->client();
+    if (!client)
+        return;
+
+    auto layerTreeView = client->layerTreeView();
+    if (layerTreeView)
+        layerTreeView->registerSelection(WebSelection(selection));
 }
 
 bool ChromeClientImpl::hasOpenedPopup() const
 {
     return m_webView->hasOpenedPopup();
 }
 
 PopupMenu* ChromeClientImpl::openPopupMenu(LocalFrame& frame, HTMLSelectElement& select)
 {
     notifyPopupOpeningObservers();
@@ skipping 233 matching lines @@
 {
     return wrapUnique(m_webView->scheduler()->createFrameScheduler(blameContext).release());
 }
 
 double ChromeClientImpl::lastFrameTimeMonotonic() const
 {
     return m_webView->lastFrameTimeMonotonic();
 }
 
 } // namespace blink