Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2230993002: Refactor composited selection code out of WebViewImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use single localFrame clearing. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2094 matching lines...) Expand 10 before | Expand all | Expand 10 after
2105 void WebViewImpl::enterFullScreenForElement(Element* element) 2105 void WebViewImpl::enterFullScreenForElement(Element* element)
2106 { 2106 {
2107 m_fullscreenController->enterFullScreenForElement(element); 2107 m_fullscreenController->enterFullScreenForElement(element);
2108 } 2108 }
2109 2109
2110 void WebViewImpl::exitFullScreenForElement(Element* element) 2110 void WebViewImpl::exitFullScreenForElement(Element* element)
2111 { 2111 {
2112 m_fullscreenController->exitFullScreenForElement(element); 2112 m_fullscreenController->exitFullScreenForElement(element);
2113 } 2113 }
2114 2114
2115 void WebViewImpl::clearCompositedSelection()
2116 {
2117 if (m_layerTreeView)
2118 m_layerTreeView->clearSelection();
2119 }
2120
2121 void WebViewImpl::updateCompositedSelection(const WebSelection& selection)
2122 {
2123 if (m_layerTreeView)
2124 m_layerTreeView->registerSelection(selection);
2125 }
2126
2127 bool WebViewImpl::hasHorizontalScrollbar() 2115 bool WebViewImpl::hasHorizontalScrollbar()
2128 { 2116 {
2129 return mainFrameImpl()->frameView()->horizontalScrollbar(); 2117 return mainFrameImpl()->frameView()->horizontalScrollbar();
2130 } 2118 }
2131 2119
2132 bool WebViewImpl::hasVerticalScrollbar() 2120 bool WebViewImpl::hasVerticalScrollbar()
2133 { 2121 {
2134 return mainFrameImpl()->frameView()->verticalScrollbar(); 2122 return mainFrameImpl()->frameView()->verticalScrollbar();
2135 } 2123 }
2136 2124
(...skipping 2474 matching lines...) Expand 10 before | Expand all | Expand 10 after
4611 return nullptr; 4599 return nullptr;
4612 return focusedFrame; 4600 return focusedFrame;
4613 } 4601 }
4614 4602
4615 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const 4603 LocalFrame* WebViewImpl::focusedLocalFrameAvailableForIme() const
4616 { 4604 {
4617 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr; 4605 return m_imeAcceptEvents ? focusedLocalFrameInWidget() : nullptr;
4618 } 4606 }
4619 4607
4620 } // namespace blink 4608 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698