Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm

Issue 2230983002: Stop using UIPasteboardChangedNotification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unittest. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
diff --git a/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm b/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
index 39f127e7c3e36a1b02bca844b4fada507af88446..670a92354c071e8c1d0ace28573b338e4a0cebb6 100644
--- a/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
+++ b/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
@@ -39,11 +39,28 @@ void SetPasteboardContent(const char* data) {
}
const char kUnrecognizedURL[] = "ftp://foo/";
const char kRecognizedURL[] = "http://bar/";
+const char kRecognizedURL2[] = "http://bar/2";
const char kAppSpecificURL[] = "test://qux/";
const char kAppSpecificScheme[] = "test";
NSTimeInterval kSevenHours = 60 * 60 * 7;
} // namespace
+class ClipboardRecentContentIOSWithFakeUptime
+ : public ClipboardRecentContentIOS {
+ public:
+ ClipboardRecentContentIOSWithFakeUptime(const std::string& application_scheme,
+ NSUserDefaults* group_user_defaults)
+ : ClipboardRecentContentIOS(application_scheme, group_user_defaults) {}
+ // Sets the uptime.
+ void SetUptime(base::TimeDelta uptime) { uptime_ = uptime; }
+
+ protected:
+ base::TimeDelta Uptime() const override { return uptime_; }
+
+ private:
+ base::TimeDelta uptime_;
+};
+
class ClipboardRecentContentIOSTest : public ::testing::Test {
protected:
ClipboardRecentContentIOSTest() {
@@ -59,8 +76,9 @@ class ClipboardRecentContentIOSTest : public ::testing::Test {
void ResetClipboardRecentContent(const std::string& application_scheme,
base::TimeDelta time_delta) {
- clipboard_content_.reset(
- new ClipboardRecentContentIOS(application_scheme, time_delta));
+ clipboard_content_.reset(new ClipboardRecentContentIOSWithFakeUptime(
+ application_scheme, [NSUserDefaults standardUserDefaults]));
+ clipboard_content_->SetUptime(time_delta);
}
void SetStoredPasteboardChangeDate(NSDate* changeDate) {
@@ -74,7 +92,7 @@ class ClipboardRecentContentIOSTest : public ::testing::Test {
}
protected:
- std::unique_ptr<ClipboardRecentContentIOS> clipboard_content_;
+ std::unique_ptr<ClipboardRecentContentIOSWithFakeUptime> clipboard_content_;
};
TEST_F(ClipboardRecentContentIOSTest, SchemeFiltering) {
@@ -153,7 +171,7 @@ TEST_F(ClipboardRecentContentIOSTest, SupressedPasteboard) {
// Check that if the pasteboard changes, the new content is not
// supressed anymore.
- SetPasteboardContent(kRecognizedURL);
+ SetPasteboardContent(kRecognizedURL2);
EXPECT_TRUE(clipboard_content_->GetRecentURLFromClipboard(&gurl));
}

Powered by Google App Engine
This is Rietveld 408576698