Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp

Issue 2230963002: SVG Image intrinsic size should be used if css style size is 'auto' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SVG intrinsic size should be used if css style size is 'auto' Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp
index 5e1703f8eddd91ef701ac1ad71fff75129f4acf4..bb97c299c4aa1870992b27417fcf19d33e77beae 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp
@@ -54,8 +54,8 @@ void LayoutSVGRect::updateShapeFromElement()
SVGLengthContext lengthContext(rect);
FloatSize boundingBoxSize(
- lengthContext.valueForLength(styleRef().width(), styleRef(), SVGLengthMode::Width),
- lengthContext.valueForLength(styleRef().height(), styleRef(), SVGLengthMode::Height));
+ styleRef().width().isAuto() ? rect->width()->currentValue()->value(lengthContext) : lengthContext.valueForLength(styleRef().width(), styleRef(), SVGLengthMode::Width),
fs 2016/08/10 18:01:34 I'd suggest to leave this alone for now. (Not sure
Shanmuga Pandi 2016/08/11 05:54:20 Acknowledged.
+ styleRef().height().isAuto() ? rect->height()->currentValue()->value(lengthContext) : lengthContext.valueForLength(styleRef().height(), styleRef(), SVGLengthMode::Height));
// Spec: "A negative value is an error."
if (boundingBoxSize.width() < 0 || boundingBoxSize.height() < 0)

Powered by Google App Engine
This is Rietveld 408576698