Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp

Issue 2230963002: SVG Image intrinsic size should be used if css style size is 'auto' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SVG intrinsic size should be used if css style size is 'auto' Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp
index f22a57e7eb8600506ff1de705e6f3c6669c5b0c2..2622abd84fe5ff3de946f4d8ec752c1aace9ca43 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGForeignObject.cpp
@@ -94,8 +94,8 @@ void LayoutSVGForeignObject::layout()
lengthContext.valueForLength(styleRef().svgStyle().x(), styleRef(), SVGLengthMode::Width),
lengthContext.valueForLength(styleRef().svgStyle().y(), styleRef(), SVGLengthMode::Height));
m_viewport = FloatRect(viewportLocation, FloatSize(
- lengthContext.valueForLength(styleRef().width(), styleRef(), SVGLengthMode::Width),
- lengthContext.valueForLength(styleRef().height(), styleRef(), SVGLengthMode::Height)));
+ styleRef().width().isAuto() ? foreign->width()->currentValue()->value(lengthContext) : lengthContext.valueForLength(styleRef().width(), styleRef(), SVGLengthMode::Width),
fs 2016/08/10 18:01:34 I guess 'auto' here would mean some form of shrink
Shanmuga Pandi 2016/08/11 05:54:20 Acknowledged.
+ styleRef().height().isAuto() ? foreign->height()->currentValue()->value(lengthContext) : lengthContext.valueForLength(styleRef().height(), styleRef(), SVGLengthMode::Height)));
if (!updateCachedBoundariesInParents)
updateCachedBoundariesInParents = oldViewport != m_viewport;

Powered by Google App Engine
This is Rietveld 408576698