third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h - Issue 2230963002: SVG Image intrinsic size should be used if css style size is 'auto'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h

Issue 2230963002: SVG Image intrinsic size should be used if css style size is 'auto' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/svg-image-intrinsic-size-with-cssstyle-auto-dynamic-image-change.html ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h

index 422847862df4f88da3edaf6c474b5068ef9d1cab..2780ab66350682cf744ef731adc4b3b53275c69f 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.h

@@ -62,12 +62,14 @@ private:

void layout() override;

void paint(const PaintInfo&, const LayoutPoint&) const override;

- void updateBoundingBox();

+ bool updateBoundingBox();

bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override;

AffineTransform localSVGTransform() const override { return m_localTransform; }

+ FloatSize calculateObjectSize() const;

bool m_needsBoundariesUpdate : 1;

bool m_needsTransformUpdate : 1;

AffineTransform m_localTransform;