third_party/WebKit/LayoutTests/svg/custom/svg-intrinsic-size-with-cssstyle-auto.html - Issue 2230963002: SVG Image intrinsic size should be used if css style size is 'auto'

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/custom/svg-intrinsic-size-with-cssstyle-auto.html

Issue 2230963002: SVG Image intrinsic size should be used if css style size is 'auto' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/custom/svg-intrinsic-size-with-cssstyle-auto-expected.html » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 image {

	4 width: auto;

	5 height: auto;

	6 }

	7 </style>

	8 <svg>

	9 <image width="100" height="100" xlink:href="data:image/png;base64,iVBORw0KGgoA AAANSUhEUgAAAHwAAABcAgMAAADR3DkbAAAACVBMVEUisUztHCT///+Wt+Z1AAAAT0lEQVR4XmNYhR/Q R35UfmooFhA1iOSBbHQwlbD8qPyo/AoGdMA1yOTR3N9Aqvyo/Kh8KAI4sEIZg0YeChDuhwK6yI/Ko4NB ID842j+j8gD+5Vkn+nqy2gAAAABJRU5ErkJggg==" />
	fs 2016/08/11 15:52:57 We should add tests for various configurations of We should add tests for various configurations of an SVG image as well - with existence and non-existence of intrinsic dimensions and ratio varying. Also, this can be written as a testharness.js test (using getBBox for example), which would make that easier. Shanmuga Pandi 2016/08/16 10:24:56 Added test with existence and non-existence of int Show quoted text On 2016/08/11 15:52:57, fs wrote: > We should add tests for various configurations of an SVG image as well - with > existence and non-existence of intrinsic dimensions and ratio varying. Also, > this can be written as a testharness.js test (using getBBox for example), which > would make that easier. Added test with existence and non-existence of intrinsic dimensions
	10 </svg>

OLD	NEW