Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: tools/push-to-trunk/merge_to_branch.py

Issue 223093003: Add version number to commit message in merge-to-branch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/merge-to-branch.sh ('k') | tools/push-to-trunk/test_scripts.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/push-to-trunk/merge_to_branch.py
diff --git a/tools/push-to-trunk/merge_to_branch.py b/tools/push-to-trunk/merge_to_branch.py
index f0acd143e4551934776b4d75503a3c9d5d604a40..87ba02b5b32552a6fec3355f9c91a77c96f30dd4 100755
--- a/tools/push-to-trunk/merge_to_branch.py
+++ b/tools/push-to-trunk/merge_to_branch.py
@@ -158,7 +158,6 @@ class FindGitRevisions(Step):
bug_aggregate = ",".join(sorted(bugs))
if bug_aggregate:
self["new_commit_msg"] += "BUG=%s\nLOG=N\n" % bug_aggregate
- TextToFile(self["new_commit_msg"], self.Config(COMMITMSG_FILE))
class ApplyPatches(Step):
@@ -181,7 +180,7 @@ class PrepareVersion(Step):
def RunStep(self):
if self._options.revert_bleeding_edge:
return
- # These version numbers are used again for creating the tag
+ # This is used to calculate the patch level increment.
self.ReadAndPersistVersion()
@@ -204,12 +203,20 @@ class IncrementVersion(Step):
else:
self.Editor(self.Config(VERSION_FILE))
self.ReadAndPersistVersion("new_")
+ self["version"] = "%s.%s.%s.%s" % (self["new_major"],
+ self["new_minor"],
+ self["new_build"],
+ self["new_patch"])
class CommitLocal(Step):
MESSAGE = "Commit to local branch."
def RunStep(self):
+ if not self._options.revert_bleeding_edge:
+ self["new_commit_msg"] = "Version %s\n\n%s" % (self["version"],
+ self["new_commit_msg"])
+ TextToFile(self["new_commit_msg"], self.Config(COMMITMSG_FILE))
self.GitCommit(file_name=self.Config(COMMITMSG_FILE))
@@ -244,10 +251,6 @@ class TagRevision(Step):
def RunStep(self):
if self._options.revert_bleeding_edge:
return
- self["version"] = "%s.%s.%s.%s" % (self["new_major"],
- self["new_minor"],
- self["new_build"],
- self["new_patch"])
print "Creating tag svn/tags/%s" % self["version"]
if self["merge_to_branch"] == "trunk":
self["to_url"] = "trunk"
« no previous file with comments | « tools/merge-to-branch.sh ('k') | tools/push-to-trunk/test_scripts.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698