Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 2230923002: [turbofan] Fix more places where IfSuccess lacks on a non-NoThrow node. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@p7
Patch Set: Fix unit test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index 786c243a10092897fb2c23d08d8a692759d17962..8ab5d8fbf3e8289980d23993323da90da99ca4be 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -889,6 +889,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {
Matcher<Node*> value_matcher =
IsToNumber(value, context, checkpoint, control);
Matcher<Node*> effect_matcher = value_matcher;
+ Matcher<Node*> control_matcher = IsIfSuccess(value_matcher);
ASSERT_TRUE(r.Changed());
EXPECT_THAT(
@@ -897,7 +898,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {
IsIntPtrConstant(bit_cast<intptr_t>(&backing_store[0])),
offset_matcher,
IsNumberConstant(array->byte_length()->Number()),
- value_matcher, effect_matcher, control));
+ value_matcher, effect_matcher, control_matcher));
}
}
}
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698