Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 2230923002: [turbofan] Fix more places where IfSuccess lacks on a non-NoThrow node. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@p7
Patch Set: Fix unit test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index bf0e237011a33de676c5b3446e71488334c3a520..51a56970995c46230bb6b80044b52a50d3f1da7c 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -1123,6 +1123,7 @@ Reduction JSTypedLowering::ReduceJSStoreProperty(Node* node) {
value = effect =
graph()->NewNode(javascript()->ToNumber(), value, context,
frame_state_for_to_number, effect, control);
+ control = graph()->NewNode(common()->IfSuccess(), value);
}
}
// Check if we can avoid the bounds check.
« no previous file with comments | « no previous file | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698