components/nacl/common/nacl_host_messages.h - Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/common/nacl_host_messages.h

Issue 22309007: Add success status to ReportTranslationFinished in ppb_nacl_private and IPC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: jvoung, dmichael reviews Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/common/nacl_host_messages.h

diff --git a/components/nacl/common/nacl_host_messages.h b/components/nacl/common/nacl_host_messages.h

index 7a395040acf9f9556c721a73c63804380617114a..d9a835ba28cc058b0d7b520395dafeb561013cbc 100644

--- a/components/nacl/common/nacl_host_messages.h

+++ b/components/nacl/common/nacl_host_messages.h

@@ -91,8 +91,9 @@ IPC_MESSAGE_CONTROL3(NaClViewMsg_NexeTempFileReply,

// A renderer sends this to the browser to report that its translation has

// finished and its temp file contains the translated nexe.

-IPC_MESSAGE_CONTROL1(NaClHostMsg_ReportTranslationFinished,

- int /* instance */)

+IPC_MESSAGE_CONTROL2(NaClHostMsg_ReportTranslationFinished,

+ int /* instance */,

+ bool /* success */)

// A renderer sends this to the browser process to report an error.

IPC_MESSAGE_CONTROL2(NaClHostMsg_NaClErrorStatus,

« no previous file with comments | « chrome/renderer/pepper/ppb_nacl_private_impl.cc ('k') | ppapi/api/private/ppb_nacl_private.idl » ('j') | no next file with comments »